Skip to content

[ModelRunner V2] Deduplicate ModelState init logic - #46776

Merged
njhill merged 2 commits into
vllm-project:mainfrom
njhill:mrv2-modelstate
Jun 26, 2026
Merged

[ModelRunner V2] Deduplicate ModelState init logic#46776
njhill merged 2 commits into
vllm-project:mainfrom
njhill:mrv2-modelstate

Conversation

@njhill

@njhill njhill commented Jun 25, 2026

Copy link
Copy Markdown
Member

Just simplification, no functional changes.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the v1 label Jun 25, 2026
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 26, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
@njhill
njhill force-pushed the mrv2-modelstate branch from b646a5a to 4c6f2df Compare June 26, 2026 00:33
@vllm-project vllm-project deleted a comment from mergify Bot Jun 26, 2026
@vllm-project vllm-project deleted a comment from mergify Bot Jun 26, 2026

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@WoosukKwon WoosukKwon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for asking!

@njhill
njhill merged commit b94f212 into vllm-project:main Jun 26, 2026
100 checks passed
@njhill
njhill deleted the mrv2-modelstate branch June 26, 2026 23:32
WindChimeRan pushed a commit to WindChimeRan/vllm that referenced this pull request Jun 27, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
wincent8 pushed a commit to wincent8/vllm that referenced this pull request Jun 29, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
Dao007forever pushed a commit to Dao007forever/vllm that referenced this pull request Jul 18, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants