[ROCm][CI TG] refactor and fix deepep_moe test group - #46758
Merged
Conversation
divakar-amd
requested review from
AndreasKaratzas,
WoosukKwon,
mgoin,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
June 25, 2026 18:55
tjtanaa
reviewed
Jun 26, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
divakar-amd
force-pushed
the
ci_fix_deepepmoe
branch
from
June 26, 2026 16:39
ec5cb60 to
cadad81
Compare
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
test_deepep_moe.pyon ROCm and consolidate MoE test accuracy checksBuffer reuse (low-latency DeepEP): The modular kernel and its DeepEP all2all buffer are now built once and reused across all token chunks instead of being re-created per chunk. Re-creating it per chunk re-initializes rocSHMEM, which only supports a single allocation per process on ROCm and aborts with "Unknown allocator type". The low-latency buffer is sized by max_tokens_per_rank/hidden_size (not chunk size), so one buffer is valid for every chunk — mirroring production, where the all2all handle is cached and reused (DeepEPLLAll2AllManager). Because the buffer is reused (and thus left dirty by the previous chunk), clean_low_latency_buffer is called before each dispatch to restore the zero-initialized regions the low-latency kernels require.
E0000h rocSHMEM Unknown allocator type SingleHeap@src/memory/single_heap.cpp:58(BUILDKITE Error LINK for reference)Accuracy check consolidation: ROCm's fp8 format (e4m3fnuz) rounds differently than NVIDIA's e4m3fn, so a few elements in the DeepEP MoE output can exceed a strict bit-for-bit tolerance even though the kernel is correct. Rather than add a bespoke comparison, this reuses the existing check_accuracy mismatch-fraction helper:
(a.) Moved
check_accuracyfromtest_ocp_mx_moe.pyinto the sharedtests/kernels/moe/utils.py(already used by cuda MXFP4/MXFP8 paths for accuracy check). test_ocp_mx_moe.py now imports it; call sites unchanged.(b.) Re-use the above
check_accuracyfor test_deepep_moe.py. The base path uses percent=1.0 (equivalent to the previous assert_close); the relaxed tolerance is gated behind current_platform.is_fp8_fnuz().Fixes:
tests/kernels/moe/test_deepep_moe.py::test_low_latency_deep_ep_moeNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.