Skip to content

[ROCm] Gate AITER MoE GateMode.INTERLEAVE on the gu-interleaved weight layout - #46664

Closed
Rohan138 wants to merge 1 commit into
vllm-project:mainfrom
Rohan138:rohan/dsv4-aiter-moe-separated-gate
Closed

[ROCm] Gate AITER MoE GateMode.INTERLEAVE on the gu-interleaved weight layout#46664
Rohan138 wants to merge 1 commit into
vllm-project:mainfrom
Rohan138:rohan/dsv4-aiter-moe-separated-gate

Conversation

@Rohan138

Copy link
Copy Markdown
Collaborator

#44893 passes GateMode.INTERLEAVE for every use_mxfp4_w4a16 model, but only gpt-oss shuffles its weights into the gate-up interleaved layout. DeepSeek-V4 keeps the separated layout, so INTERLEAVE routes small-M decode to an a16w4 path with no kernel → RuntimeError: Unsupported kernel config for moe heuristic dispatch. This marks the separated path and gates INTERLEAVE on it; gpt-oss is unchanged.

Not a duplicate: #46122 takes the opposite approach (move DSV4 onto gu-interleave + AITER_BF16_FP8_MOE_BOUND=0); this keeps DSV4 on the working SEPARATED path with no env-var workaround.

Test: pre-commit run --files <changed> passes. The resulting SEPARATED routing serves + decodes DeepSeek-V4-Pro (TP8, gfx950) — gsm8k 5-shot 0.945 — whereas the default INTERLEAVE crashes at startup with the dispatch error above.

AI assistance (Claude) was used.

vllm-project#44893 passes GateMode.INTERLEAVE for all use_mxfp4_w4a16 models, but
only gpt-oss shuffles weights into the gate-up interleaved layout.
DeepSeek-V4 keeps the separated layout, so INTERLEAVE routed its small-M
decode to an a16w4 path with no kernel ("Unsupported kernel config for
moe heuristic dispatch"). Mark the separated path and gate INTERLEAVE on
it so DeepSeek-V4 uses SEPARATED while gpt-oss is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
@mergify mergify Bot added the rocm Related to AMD ROCm label Jun 24, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jun 24, 2026
@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Rohan138.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 26, 2026
@Rohan138 Rohan138 closed this Jun 30, 2026
@Rohan138
Rohan138 deleted the rohan/dsv4-aiter-moe-separated-gate branch June 30, 2026 16:59
@Rohan138

Copy link
Copy Markdown
Collaborator Author

Closed in favor of #46122

@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant