[Build] Update vllm to point to vllm-project/flash-attention commit that builds FA3 with torch stable API. - #46644
Merged
simon-mo merged 6 commits intoJun 27, 2026
Conversation
…abi stable FA3 api. If this passes the CI, we will merge that fork with vllm-project/flash-attention, then we will point to the new tag here Signed-off-by: Chris Leonard <chleonar@redhat.com>
cleonard530
requested review from
Harry-Chen,
LucasWilkinson and
tlrmchlsmth
as code owners
June 24, 2026 18:11
Member
|
Triggered a CI pipeline to test building |
Contributor
Author
|
Thanks @Harry-Chen. Non of these failures seem to be caused by the updates to FA3. |
Member
|
@cleonard530 It is merged! Could you please change the commit ref to the main repo? (and the commit title) |
…t with torch stable abi fa3 build Signed-off-by: Chris Leonard <chleonar@redhat.com>
Contributor
Author
|
Thanks @Harry-Chen, just updated the GIT_TAG! |
Harry-Chen
enabled auto-merge (squash)
June 25, 2026 17:39
Contributor
Author
|
@Harry-Chen, I checked each of these failures and I don't think they were coming from this PR. Also, since the test passed before when the tag pointed to my flash-attention fork, I don't think the last change would of broken anything. Can you please rerun the failed test and try to merge this? |
WindChimeRan
pushed a commit
to WindChimeRan/vllm
that referenced
this pull request
Jun 27, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
wincent8
pushed a commit
to wincent8/vllm
that referenced
this pull request
Jun 29, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
4 tasks
rjrock
pushed a commit
to rjrock/vllm
that referenced
this pull request
Jul 1, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
4 tasks
Dao007forever
pushed a commit
to Dao007forever/vllm
that referenced
this pull request
Jul 18, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…hat builds FA3 with torch stable API. (vllm-project#46644)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
As a part of #26946. Updated vllm_flash_attn.cmake to use FA fork that builds a libtorch ABI stable FA3 library.
Currently, this is pointing towards my flash-attention fork but if this passes the CI, we will merge that fork with vllm-project/flash-attention, then we will point to the new tag.
see vllm-project/flash-attention#152 to see the commit it is pointing to.
cc @janeyx99 @Harry-Chen
Test Plan
build with new flash-attention commit
pytest tests/kernels/attention/test_flash_attn.py -k "3"Test Result
Build succeded
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Migration progress of vLLM using the Audit Python extension torch-abi-audit: