Conversation
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lesj0610
marked this pull request as draft
June 24, 2026 02:38
lesj0610
added a commit
to lesj0610/vllm
that referenced
this pull request
Aug 22, 2026
Upstream's warmup infrastructure (vllm-project#50174) registers these kernels through its own provider registry, so the fork-side warmup hooks are redundant. Reverse-apply the deltas of the upstream warmup PRs (vllm-project#42193, vllm-project#42215, vllm-project#43642, vllm-project#46446) so every file they touched matches origin/main: - Drop the fused MoE, TurboQuant, hybrid GDN/Mamba/MRoPE and block-table warmup modules plus their tests and kernel_warmup wiring. - Restore triton_decode_attention, triton_turboquant_decode, fused_recurrent and fused_moe to upstream (removes the VllmJitKernel wrappers those PRs introduced). - Keep `import math` in mrope.py: it is used by the bounded M-RoPE cache work, not by the reverted warmup code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The old V1
BlockTableslot-mapping Triton kernel can be first touched after startup warmup, when the JIT monitor is already active.The normal model dummy/profile runs do not directly exercise
BlockTable.compute_slot_mapping()for every runtime-specialized request shape. When the first real request hits an uncovered shape,_compute_slot_mapping_kernelcan still compile during inference.Approach
BlockTable.warmup_compute_slot_mapping()andMultiGroupBlockTable.warmup_compute_slot_mapping()so the warmup goes through the same V1 block-table wrapper that runtime input preparation uses.BlockTableslot-mapping path. V2 GPU block-table and KV-zeroing warmup paths are not changed here.This keeps the warmup near the owner of the slot-mapping kernel contract instead of adding a broader synthetic kernel launcher.
Test Plan
Test Result
py_compile: passedruff check: passedruff format --check: passedtests/v1/worker/test_block_table_warmup.py: 2 passedgit diff --check: passedGPU runtime smoke was not rerun for this standalone PR, so absence of runtime JIT warnings remains to be validated on a CUDA serving run.
Checklist
AI assistance: Codex.