Skip to content

[Perf] Skip detokenization in online beam search #46422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 3 commits into from
Jun 23, 2026
Merged

[Perf] Skip detokenization in online beam search #46422

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
837d5b3
[Perf] Skip detokenization in online beam search
GuyStone Jun 22, 2026
3e724a2
remove beam search detokenize code comment
GuyStone Jun 23, 2026
d78bea4
Update vllm/entrypoints/generate/beam_search/online.py
GuyStone Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/entrypoints/generate/beam_search/online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
logprobs=logprobs_num,
max_tokens=1,
temperature=temperature,
detokenize=False,
detokenize=False,

Check failure on line 65 in vllm/entrypoints/generate/beam_search/online.py

View workflow job for this annotation

GitHub Actions / pre-commit

Ruff (invalid-syntax) 

vllm/entrypoints/generate/beam_search/online.py:65:13: invalid-syntax: Duplicate keyword argument "detokenize"
Comment thread
GuyStone marked this conversation as resolved.
Resolved
)
all_beams = [
BeamSearchSequence(
Expand Down
Loading