Revert "[DSv4 Perf] DSv4 flashinfer sparse index cache for metadata, 2%~4% TTFT improvement" (#45863) - #45979
Closed
vllm-agent wants to merge 1 commit into
Closed
Revert "[DSv4 Perf] DSv4 flashinfer sparse index cache for metadata, 2%~4% TTFT improvement" (#45863)#45979vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
…2%~4% TTFT improvement (vllm-project#45863)" This reverts commit 0a7bacd.
Member
|
Retested this in main and it is not the reason =========================== 1 passed, 16 warnings in 384.38s (0:06:24) ============================
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute
(yewentao256) [yewentao256@ip-172-31-44-248 vllm-source]$ pytest -s -v tests/evals/gsm8k/test_gsm8k_correctness.py --config-list-file=tests/evals/gsm8k/configs/moe-refactor/config-b200.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #45863
This reverts commit 0a7bacd (merge commit of PR #45863).
Reason: CI nightly build #72766 detected a critical accuracy regression in the
MoE Refactor Integration Test (B200 - TEMPORARY)job. The testtest_gsm8k_correctness[DeepSeek-V4-Flash-deepgemm-mega-moe]reported GSM8K accuracy of 6.75%, far below the expected threshold of 87%.PR #45863 changed DSv4 flashinfer sparse index cache files (
vllm/models/deepseek_v4/nvidia/flashinfer_sparse.py,vllm/v1/attention/backends/mla/sparse_swa.py) which are directly related to the DeepSeek-V4 inference path.Note: PR #45309 (which also changed DSv4 attention code) has already been reverted separately in #45972.
Linked failures (1):
MoE Refactor Integration Test (B200 - TEMPORARY)— GSM8K accuracy 0.0675 < 0.87Auto-generated by CI failure analyzer.