[Bugfix] Treat explicit parallel_tool_calls=null as the documented default - #45355
HumphreySun98 wants to merge 1 commit into
Conversation
…fault
An explicit 'parallel_tool_calls: null' was filtered like 'false'
(trimming the response to a single tool call) because the filter gated
on truthiness. The field is documented as defaulting to true, and an
omitted field correctly keeps all tool calls -- explicit null means
'unspecified' and must resolve the same way.
Gate on 'is not False' so only an explicit false trims, matching the
docstring ('when parallel_tool_calls is False') and the Rust frontend's
unwrap_or(true) semantics.
Adds unit tests covering omitted/true/false/null on both the full and
streaming response paths.
Fixes vllm-project#44948.
Signed-off-by: HumphreySun98 <humphreysun98@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in PRs do not trigger a full CI run by default. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. Agent GuidelinesIMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban. 🚀 |
1 participant
Purpose
Fixes #44948.
An explicit `parallel_tool_calls: null` was filtered like `false` (trimming the response to a single tool call) because `maybe_filter_parallel_tool_calls` gated on truthiness (`if request.parallel_tool_calls:`). The field is documented as defaulting to `true`, and an omitted field correctly keeps all tool calls — explicit `null` means "unspecified" and must resolve to the same default.
Fix: gate on `request.parallel_tool_calls is not False`, so only an explicit `false` trims — matching the function's own docstring ("when parallel_tool_calls is False") and the Rust frontend's `unwrap_or(true)` semantics (#44760).
Duplicate-work check
Per `AGENTS.md`: `gh pr list --search "44948"` / `"parallel_tool_calls null"` — no other PR addresses this.
Test Plan
New `tests/entrypoints/openai/test_tool_calls_utils.py` (`@pytest.mark.cpu_test`, no GPU/network) covering omitted / `true` / `false` / `null` on both the full-response and streaming paths — 6 tests, including the two explicit-`null` regression cases.
Test Result
```
$ python -m pytest tests/entrypoints/openai/test_tool_calls_utils.py -v
==== 6 passed in 14.92s ====
$ pre-commit run --files vllm/entrypoints/serve/utils/tool_calls_utils.py tests/entrypoints/openai/test_tool_calls_utils.py
ruff check / ruff format / typos / mypy / SPDX ... all Passed
```
cc @njhill @chaunceyjiang (cc'd on the issue)
AI assistance disclosure
This change was AI-assisted (Claude). I (the submitter) reviewed every line, ran the tests above, and stand behind the change end-to-end.