[bugfix] skip conch kernel for g_idx reordering - #45072
Merged
Merged
Conversation
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
AndreasKaratzas
approved these changes
Jun 9, 2026
AndreasKaratzas
added
the
ready
wcynb1023
pushed a commit
to wcynb1023/vllm
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Dao007forever
pushed a commit
to Dao007forever/vllm
that referenced
this pull request
Jul 18, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conch kernel doesn't support g_idx reordering.
The issue is not ROCm specific. CUDA fails to capture this because the kernel ordering on cuda picks Marlin kernel before conch which handles g_idx reordering.
Kernel ordering preference for ROCm & CUDA can be referred here - LINK
Resolves the following test:
lora/test_quant_model.py::test_quant_model_lora[model0]. This PR will safely skip selecting the conchkernel and on rocm the next kernel (ExllamaLinearKernel) in the preference order will be chosen.