[Bugfix] Fix nemotron accuracy drop introduced by #41184 - #45037
Merged
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
DarkLight1337
approved these changes
Jun 9, 2026
DarkLight1337
enabled auto-merge (squash)
June 9, 2026 16:08
robertgshaw2-redhat
approved these changes
Jun 9, 2026
Contributor
|
Additional validation on another model that hits the same generic DeepSeek/FusedMoE routed-scale path:
This matches the root cause described in this PR: when apply_routed_scale_to_output=True, RoutedExperts must receive the router-side scale (1.0) while MoERunner owns the output-side scale. |
robertgshaw2-redhat
disabled auto-merge
June 10, 2026 17:16
robertgshaw2-redhat
merged commit Jun 10, 2026
2902668
into
vllm-project:main
78 of 80 checks passed
wcynb1023
pushed a commit
to wcynb1023/vllm
that referenced
this pull request
Jun 11, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
Dao007forever
pushed a commit
to Dao007forever/vllm
that referenced
this pull request
Jul 18, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…llm-project#45037) Signed-off-by: Bill Nell <bnell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The routed_scaling_factor was getting applied twice in the Nemotron model. We needed to check
apply_routed_scaling_factor_to_outputbefore passing the scaling factor onto theRoutedExperts.Test Plan
Test Result
Test passed.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.