fix: Pin Ray placement group bundles to allowlisted nodes during scale up#44762
Open
weizhoublue wants to merge 1 commit into
Open
fix: Pin Ray placement group bundles to allowlisted nodes during scale up#44762weizhoublue wants to merge 1 commit into
weizhoublue wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
@walterbm please help check whether this PR makes sense , thanks |
walterbm
reviewed
Jun 8, 2026
| "There can only be one head node" | ||
| ) | ||
|
|
||
| # optionally restrict DP placement to a caller-provided node set. |
Contributor
There was a problem hiding this comment.
maybe this can be extracted into a helper to avoid duplication across both checks
Contributor
Author
There was a problem hiding this comment.
sounds good. thanks
I updated it
Contributor
good catch! looks reasonable to me |
Signed-off-by: weizhoublue <weizhou.lan@daocloud.io>
weizhoublue
force-pushed
the
fix-elastic-scale-dp-placement-node-allowlist
branch
from
fa955a0 to
950d360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Root Cause
PR #44669 restricted placement groups to allowlisted nodes only during initial deployment (via create_dp_placement_groups ).
Scale-up workflow routing through utils.py ignores VLLM_RAY_DP_PLACEMENT_NODE_IPS environment variable. Furthermore, it creates Ray placement group bundles without node-specific resource constraints, allowing Ray scheduler to bypass desired layout.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.