Skip to content

[Rust Frontend]: Add /tokenize API support with Completion format - #44730

Closed
coder3101 wants to merge 4 commits into
vllm-project:mainfrom
asharkhan3101:ashar/tokenize-chat
Closed

coder3101 wants to merge 4 commits into
vllm-project:mainfrom
asharkhan3101:ashar/tokenize-chat

Conversation

@coder3101

@coder3101 coder3101 commented Jun 6, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

For the purpose of feature parity of rust frontend with python. It is being tracked #44280

Test Plan

  • cargo fmt --check --package vllm-text --package vllm-chat --package vllm-server --package vllm-engine-core-client --package vllm-mock-engine
  • cargo nextest run -p vllm-text -p vllm-chat -p vllm-server -p vllm-engine-core-client -p vllm-mock-engine

Test Result

  • cargo fmt --check ... : passed
  • cargo nextest run -p : 494 passed, 1 failed, 1 skipped (unrelated failing test vllm-text lower::tests::lower_text_request_uses_real_qwen_generation_defaults )

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

asharkhan3101 and others added 3 commits June 6, 2026 03:19
Signed-off-by: mohammadkhan <mohammadkhan@digitalocean.com>
Signed-off-by: Ashar <ashar786khan@gmail.com>
Signed-off-by: Ashar <ashar786khan@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

PRs do not trigger a full CI run by default. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

Agent Guidelines

IMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban.

🚀

@mergify mergify Bot added the rust label Jun 6, 2026
@tahsintunan

Copy link
Copy Markdown
Contributor

I believe this overlaps with #44222, which adds /tokenize plus /detokenize and handles both the chat and completion forms, so it's the broader version and already in active review. I'd suggest consolidating there and closing this one in its favor.

Also, for future reference:

vllm/AGENTS.md

Lines 6 to 19 in 228bcc4

## 1. Contribution Policy (Mandatory)
### Duplicate-work checks
Before proposing a PR, run these checks:
```bash
gh issue view <issue_number> --repo vllm-project/vllm --comments
gh pr list --repo vllm-project/vllm --state open --search "<issue_number> in:body"
gh pr list --repo vllm-project/vllm --state open --search "<short area keywords>"
```
- If an open PR already addresses the same fix, do not open another.
- If your approach is materially different, explain the difference in the issue.

@coder3101 coder3101 closed this Jun 7, 2026
@coder3101
coder3101 deleted the ashar/tokenize-chat branch June 7, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants