[ROCm][Bugfix] Make intermediate_pad TP-aware in rocm_aiter_fused_experts - #44679
Merged
dllehr-amd merged 7 commits intoJun 10, 2026
Merged
Conversation
…erts Tracking issue: ROCM-25603. Regressing PR: vllm-project#42098. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Rohan138
marked this pull request as draft
June 5, 2026 18:39
Rohan138
marked this pull request as ready for review
June 5, 2026 18:46
dllehr-amd
approved these changes
Jun 5, 2026
dllehr-amd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @Rohan138 for the quick fix. and the explanation for needing to adjust the intermediate padding! Approving, and we can tackle any additional issues when we bump Aiter again
tjtanaa
approved these changes
Jun 6, 2026
Contributor
|
Hi @Rohan138, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Member
|
Adding it to milestone -- Fixes critical GPT OSS accuracy regression. |
wcynb1023
pushed a commit
to wcynb1023/vllm
that referenced
this pull request
Jun 11, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
3 tasks
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Dao007forever
pushed a commit
to Dao007forever/vllm
that referenced
this pull request
Jul 18, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…erts (vllm-project#44679) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the GSM8K accuracy regression on the AITER MoE path at TP>1 introduced by #42098. This is because FlyDSL and CKTile MoE follow different conventions for hidden_pad/intermediate_pad in AITER, and the
aiter.fused_moedispatcher uses FlyDSL on TP1 but CKTile on TP8. This will partially be fixed on the AITER side in 0.1.15 by ROCm/aiter#3401.On openai/gpt-oss-120b BF16 at TP=8 on MI355X, lm_eval GSM8K
flexible-extract drops from 0.896 (v0.21.0) to 0.684 (v0.22.0).
Bisected to #42098 changing
intermediate_padinrocm_aiter_fused_expertstointermediate_pad // 64 * 64 * 2.Test Plan
Test Result
openai/gpt-oss-120b BF16 on MI355X, 1k/1k random, mc=32:
TP=1 throughput within noise of the baseline; TP=8 accuracy is
recovered to v0.21.0 levels.
AI assistance (Claude) was used to bisect the regression, design and
verify this fix.