Skip to content

[ROCm][Bugfix] Make intermediate_pad TP-aware in rocm_aiter_fused_experts - #44679

Merged
dllehr-amd merged 7 commits into
vllm-project:mainfrom
Rohan138:rohan/fix-rocm-aiter-moe-pad-tp-aware
Jun 10, 2026
Merged

[ROCm][Bugfix] Make intermediate_pad TP-aware in rocm_aiter_fused_experts#44679
dllehr-amd merged 7 commits into
vllm-project:mainfrom
Rohan138:rohan/fix-rocm-aiter-moe-pad-tp-aware

Conversation

@Rohan138

@Rohan138 Rohan138 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Fix the GSM8K accuracy regression on the AITER MoE path at TP>1 introduced by #42098. This is because FlyDSL and CKTile MoE follow different conventions for hidden_pad/intermediate_pad in AITER, and the aiter.fused_moe dispatcher uses FlyDSL on TP1 but CKTile on TP8. This will partially be fixed on the AITER side in 0.1.15 by ROCm/aiter#3401.

On openai/gpt-oss-120b BF16 at TP=8 on MI355X, lm_eval GSM8K
flexible-extract drops from 0.896 (v0.21.0) to 0.684 (v0.22.0).
Bisected to #42098 changing intermediate_pad in
rocm_aiter_fused_experts to intermediate_pad // 64 * 64 * 2.

Test Plan

# Serve TP=8
VLLM_ROCM_USE_AITER=1 vllm serve openai/gpt-oss-120b \
    --dtype auto -tp 8 --no-enable-prefix-caching \
    --disable-uvicorn-access-log \
    --attention-backend ROCM_AITER_UNIFIED_ATTN

# Throughput
vllm bench serve --model openai/gpt-oss-120b \
    --dataset-name random --ignore-eos \
    --random-input-len 1024 --random-output-len 1024 \
    --max-concurrency 32 --num-prompts 64

# Accuracy
lm_eval --model local-completions \
    --model_args model=openai/gpt-oss-120b,base_url=http://localhost:8000/v1/completions,max_gen_toks=2048,num_concurrent=256,max_retries=10 \
    --tasks gsm8k --batch_size 1 --limit 250 --apply_chat_template

Test Result

openai/gpt-oss-120b BF16 on MI355X, 1k/1k random, mc=32:

Variant TP=1 tput TP=1 lmeval TP=8 tput TP=8 lmeval
Baseline (#42098) 3200 t/s 0.905 5392 t/s 0.684 ❌
TP-aware (PR) 3189 0.900 5168 0.892

TP=1 throughput within noise of the baseline; TP=8 accuracy is
recovered to v0.21.0 levels.

AI assistance (Claude) was used to bisect the regression, design and
verify this fix.

…erts

Tracking issue: ROCM-25603.
Regressing PR: vllm-project#42098.

Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added rocm Related to AMD ROCm bug Something isn't working labels Jun 5, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jun 5, 2026
@Rohan138
Rohan138 marked this pull request as draft June 5, 2026 18:39
@Rohan138
Rohan138 marked this pull request as ready for review June 5, 2026 18:46

@dllehr-amd dllehr-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rohan138 for the quick fix. and the explanation for needing to adjust the intermediate padding! Approving, and we can tackle any additional issues when we bump Aiter again

@dllehr-amd dllehr-amd added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 5, 2026
@mergify

mergify Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi @Rohan138, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

@dllehr-amd
dllehr-amd merged commit 5b6b536 into vllm-project:main Jun 10, 2026
80 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jun 10, 2026
@AndreasKaratzas AndreasKaratzas added this to the v0.23.0 cherry picks milestone Jun 10, 2026
@AndreasKaratzas

Copy link
Copy Markdown
Member

Adding it to milestone -- Fixes critical GPT OSS accuracy regression.

wcynb1023 pushed a commit to wcynb1023/vllm that referenced this pull request Jun 11, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
khluu pushed a commit that referenced this pull request Jun 11, 2026
…erts (#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
(cherry picked from commit 5b6b536)
Saddss pushed a commit to Saddss/vllm that referenced this pull request Jun 14, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
vivek8123 pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Jun 18, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
divineearthly pushed a commit to divineearthly/vllm that referenced this pull request Jun 19, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: divineearthly <divineearthly@gmail.com>
nkzhenhua pushed a commit to nkzhenhua/vllm that referenced this pull request Jun 24, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Dao007forever pushed a commit to Dao007forever/vllm that referenced this pull request Jul 18, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
…erts (vllm-project#44679)

Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants