Skip to content

[Bugfix] Fix ZMQ port TOCTOU race in shm_broadcast.py #44495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RTCartist wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

[Bugfix] Fix ZMQ port TOCTOU race in shm_broadcast.py #44495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions vllm/distributed/device_communicators/shm_broadcast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from vllm.platforms import current_platform
from vllm.utils.network_utils import (
get_ip,
get_open_port,
get_open_zmq_inproc_path,
get_open_zmq_ipc_path,
is_valid_ipv6_address,
Expand Down Expand Up @@ -425,14 +424,16 @@ def __init__(
connect_ip = get_ip()
self.remote_socket = context.socket(XPUB)
self.remote_socket.setsockopt(XPUB_VERBOSE, True)
remote_subscribe_port = get_open_port()
if is_valid_ipv6_address(connect_ip):
self.remote_socket.setsockopt(IPV6, 1)
remote_addr_ipv6 = True
connect_ip = f"[{connect_ip}]"
socket_addr = f"tcp://{connect_ip}:{remote_subscribe_port}"
self.remote_socket.bind(socket_addr)
remote_subscribe_addr = f"tcp://{connect_ip}:{remote_subscribe_port}"
# Bind to port 0 so the OS assigns a port atomically,
# avoiding TOCTOU race with get_open_port(). (See #28498)
self.remote_socket.bind(f"tcp://{connect_ip}:0")
remote_subscribe_addr = (
self.remote_socket.getsockopt(zmq.LAST_ENDPOINT).decode()
)
else:
remote_subscribe_addr = None
self.remote_socket = None
Expand Down
Loading