Skip to content

[MM][CG] Simplify ViT CUDA graph interfaces - #44484

Merged
Isotr0py merged 2 commits into
vllm-project:mainfrom
shen-shanshan:vit-cg-2
Jun 8, 2026
Merged

[MM][CG] Simplify ViT CUDA graph interfaces#44484
Isotr0py merged 2 commits into
vllm-project:mainfrom
shen-shanshan:vit-cg-2

Conversation

@shen-shanshan

@shen-shanshan shen-shanshan commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Following #41234, this PR add default value ("image") for get_input_modality() to simplify ViT cuda graph interfaces. Thus, for image-only VLMs, they don't need to overwrite the get_input_modality() interface anymore.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: shen-shanshan <467638484@qq.com>
@shen-shanshan

Copy link
Copy Markdown
Collaborator Author

CC @Isotr0py

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Jun 4, 2026
@Isotr0py
Isotr0py enabled auto-merge (squash) June 4, 2026 03:27
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 4, 2026
@Isotr0py
Isotr0py merged commit 8fb0274 into vllm-project:main Jun 8, 2026
54 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Jun 8, 2026
knight0528 pushed a commit to knight0528/vllm that referenced this pull request Jun 8, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
edwardquarm added a commit to edwardquarm/vllm that referenced this pull request Jun 9, 2026
…m-project#44484

- Add evaluation outputs showing comparison tables
- Add CI evidence files with test run data
- Add LLM selector replay outputs with inputs

These serve as examples for running the ATS workflow.
ekagra-ranjan pushed a commit to ekagra-ranjan/vllm that referenced this pull request Jun 9, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
waqahmed-amd-fi pushed a commit to waqahmed-amd-fi/vllm that referenced this pull request Jun 10, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
oguzhankir added a commit to oguzhankir/vllm that referenced this pull request Jun 14, 2026
- docs: switch Kimi-VL row to ❌︎ for table consistency (vllm-project#41992 review).
- kimi_vl: drop redundant get_input_modality override now that
  SupportsEncoderCudaGraph defaults to image (vllm-project#44484).
- kimi_vl: use ceil for per_mm_item_output so the capture buffer fits
  the worst case of one item using the full budget when token_budget is
  not a multiple of max_batch_size (matches vllm-project#38040 in qwen3_vl).
- moonvit: rename normalized -> grid_pairs and drop the empty-list
  guard inside prepare_encoder_metadata; the helper is never called
  with an empty grid (matches qwen3_vl convention).
- moonvit: narrow prepare_encoder_metadata docstring to reflect that
  it is currently only used by the CUDA graph capture/replay paths.

Signed-off-by: oguz <oguzhankir17@gmail.com>
Saddss pushed a commit to Saddss/vllm that referenced this pull request Jun 14, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
vivek8123 pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Jun 18, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
divineearthly pushed a commit to divineearthly/vllm that referenced this pull request Jun 19, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: divineearthly <divineearthly@gmail.com>
nkzhenhua pushed a commit to nkzhenhua/vllm that referenced this pull request Jun 24, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
ohsono pushed a commit to ohsono/vllm that referenced this pull request Jul 3, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
Dao007forever pushed a commit to Dao007forever/vllm that referenced this pull request Jul 18, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants