[CI] Resolve release V2 docker build after ROCm CI wheels change - #44463
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
marked this pull request as ready for review
June 3, 2026 23:48
AndreasKaratzas
added
the
ready
khluu
approved these changes
Jun 4, 2026
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
JisoLya
pushed a commit
to JisoLya/vllm
that referenced
this pull request
Jun 5, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: JisoLya <523420504@qq.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Jackie2049
pushed a commit
to Jackie2049/vllm
that referenced
this pull request
Jun 12, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
ohsono
pushed a commit
to ohsono/vllm
that referenced
this pull request
Jul 3, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…m-project#44463) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Docker builds were failing with
Repo is dirtybecause tracked files excluded by.dockerignorewere missing from the container worktree while.gitwas still available for the cleanliness check. This keeps.clang-formatand.gitattributesin the Docker context, while continuing to ignore non-build paths such asdocs/,.github/,.pre-commit-config.yaml, andformat.sh. To make that safe,tools/check_repo.shrestores only those intentionally omitted tracked paths from the Git index before runninggit diff --quietinside Docker. This preserves the smaller Docker context for CI base builds without making release builds see false dirty-tree changes. Verified withgit diff --check,bash -n tools/check_repo.sh, and a temp worktree simulation with the ignored tracked paths removed.