[LoRA] Fix dedup for post-replacement module aliases#44413
Merged
Conversation
Contributor
Author
|
CC @jeejeelee |
jeejeelee
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #42757 by fixing another shared-alias LoRA registration case.
#42757 deduplicated LoRA wrapping when the same original module is reachable
through multiple attribute paths, such as the MoE gate alias. However, it only
tracked the id of the original module before replacement.
This misses alias paths that resolve to the already-replaced LoRA wrapper. For
example, in Gemma4,
self_decoder.decoder_layersaliaseslayers. After thecanonical
layers.*path is wrapped, the alias path later sees the newBaseLayerWithLoRAobject, not the original module. Since the wrapper id wasnot tracked, the same wrapper could still be registered twice.
During adapter activation, the canonical module name loads the LoRA weights, but
the alias module name has no matching adapter key and resets the same wrapper,
effectively clearing the LoRA weights.
This PR records both the original module id and the replacement wrapper id, so
both pre-replacement and post-replacement alias paths reuse the existing wrapper
without adding a second
self.modulesentry.Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.