[Refactor] Suppress SyntaxWarning from ast.literal_eval in tool parsers#44346
Merged
Conversation
Signed-off-by: sfeng33 <4florafeng@gmail.com>
sfeng33
requested review from
aarnphm,
bbrowning and
chaunceyjiang
as code owners
Collaborator
Author
|
@claude review |
Collaborator
Author
|
@codex review |
yewentao256
approved these changes
Jun 3, 2026
yewentao256
left a comment
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…rs (vllm-project#44346) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
JisoLya
pushed a commit
to JisoLya/vllm
that referenced
this pull request
Jun 5, 2026
…rs (vllm-project#44346) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: JisoLya <523420504@qq.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
…rs (vllm-project#44346) Signed-off-by: sfeng33 <4florafeng@gmail.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
…rs (vllm-project#44346) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…rs (vllm-project#44346) Signed-off-by: sfeng33 <4florafeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Python 3.12+ emits
SyntaxWarningfor invalid escape sequences (e.g.\pinC:\path). LLM-generated tool call arguments can contain these, producing noisy warnings in server logs. This PR suppress the warning by usingsafe_literal_eval().Test Plan