Skip to content

[CI] Align PD tests to HMA on by default#44174

Merged
DarkLight1337 merged 2 commits into
vllm-project:mainfrom
NickLucche:hma-on-tests
Jun 3, 2026
Merged

[CI] Align PD tests to HMA on by default#44174
DarkLight1337 merged 2 commits into
vllm-project:mainfrom
NickLucche:hma-on-tests

Conversation

@NickLucche
Copy link
Copy Markdown
Member

#41847 switched HMA from opt-in to opt-out, completing its experimental cycle.
Connectors that support it will now have it turned on by default unless otherwise specified.

This PR is a follow up to that to make sure our CI for the PD related tests is aligned to this, moving to testing the auto behavior rather than explicitely turning HMA on with --no-disable-hybrid-kv-cache-manager

Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche NickLucche added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 1, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 1, 2026

Hi @NickLucche, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@DarkLight1337 DarkLight1337 merged commit df7252c into vllm-project:main Jun 3, 2026
22 checks passed
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
JisoLya pushed a commit to JisoLya/vllm that referenced this pull request Jun 5, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: JisoLya <523420504@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kv-connector ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants