Revert "[Bugfix] Fix RMSNorm kernels to multiply in weight's native dtype" (#42379) - #44088
Open
vllm-agent wants to merge 4 commits into
Open
Revert "[Bugfix] Fix RMSNorm kernels to multiply in weight's native dtype" (#42379)#44088vllm-agent wants to merge 4 commits into
vllm-agent wants to merge 4 commits into
Conversation
…type (vllm-project#42379)" This reverts commit 124fac1.
zyongye
added
verified
Align the vLLM IR rms_norm/fused_add_rms_norm native reference implementations (and the IR design doc) with the reverted CUDA kernel behavior: keep activations in fp32 through the weight multiply and cast back to the original dtype only at the end, instead of downcasting to the weight's native dtype before multiplying. Also drop the now-obsolete GemmaRMSNorm docstring note about (x * w).to(orig_dtype), since the base RMSNorm now does the same. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Yongye Zhu <zyy1102000@gmail.com>
Contributor
|
Documentation preview: https://vllm--44088.org.readthedocs.build/en/44088/ |
zyongye
approved these changes
Jun 2, 2026
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #42379
This reverts commit 124fac1 (merge commit for PR #42379).
Original PR: #42379
Original title: [Bugfix] Fix RMSNorm kernels to multiply in weight's native dtype
Reason for revert
CI nightly build #69058 detected 1 new failure linked to this PR:
test_batched_generationfor audioflamingo3 failed with text output mismatch. The RMSNorm kernel dtype fix changes numerical precision of the normalization output, which propagates through model layers and alters generated text.Files reverted
csrc/libtorch_stable/layernorm_kernels.cucsrc/libtorch_stable/layernorm_quant_kernels.cuAuto-generated by CI failure analyzer. Build #69058.