[FlashAttention] Sync FA with upstream#44065
Conversation
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
| vllm-flash-attn | ||
| GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git | ||
| GIT_TAG bce29425653ec0fbc579d329883030e832d15ada | ||
| GIT_REPOSITORY https://github.com/MatthewBonanni/flash-attention.git |
There was a problem hiding this comment.
⚪ Severity: LOW
The dependency source is changed from the official vllm-project/flash-attention organization repository to a personal fork (MatthewBonanni/flash-attention). Personal repos lack organizational branch protections and required reviewers. If this account were compromised, malicious code could be injected into all downstream builds via this fetch path.
Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Replace the personal fork URL (MatthewBonanni/flash-attention) with the official organization repository (vllm-project/flash-attention). Since the PR description references an upstream PR (vllm-project/flash-attention#141), this change should be reverted to use the official repo once that upstream PR is merged. Using a personal fork, even with a pinned commit hash, introduces availability risk (if the fork is deleted, builds break) and deviates from the project's established supply-chain pattern where all other dependencies point to organizational repos.
⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.
| GIT_REPOSITORY https://github.com/MatthewBonanni/flash-attention.git | |
| GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git |
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
LucasWilkinson
left a comment
There was a problem hiding this comment.
Thanks for doing this!
|
👀 |
Purpose
Corresponding PR: vllm-project/flash-attention#141
Test Plan
CI
Test Result
TBD
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.