Skip to content

[FlashAttention] Sync FA with upstream#44065

Merged
vllm-bot merged 4 commits into
vllm-project:mainfrom
MatthewBonanni:sync_fa_2
Jun 2, 2026
Merged

[FlashAttention] Sync FA with upstream#44065
vllm-bot merged 4 commits into
vllm-project:mainfrom
MatthewBonanni:sync_fa_2

Conversation

@MatthewBonanni
Copy link
Copy Markdown
Member

@MatthewBonanni MatthewBonanni commented May 30, 2026

Purpose

Corresponding PR: vllm-project/flash-attention#141

Test Plan

CI

Test Result

TBD


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
vllm-flash-attn
GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git
GIT_TAG bce29425653ec0fbc579d329883030e832d15ada
GIT_REPOSITORY https://github.com/MatthewBonanni/flash-attention.git
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: LOW

The dependency source is changed from the official vllm-project/flash-attention organization repository to a personal fork (MatthewBonanni/flash-attention). Personal repos lack organizational branch protections and required reviewers. If this account were compromised, malicious code could be injected into all downstream builds via this fetch path.
Helpful? Add 👍 / 👎

💡 Fix Suggestion

Suggestion: Replace the personal fork URL (MatthewBonanni/flash-attention) with the official organization repository (vllm-project/flash-attention). Since the PR description references an upstream PR (vllm-project/flash-attention#141), this change should be reverted to use the official repo once that upstream PR is merged. Using a personal fork, even with a pinned commit hash, introduces availability risk (if the fork is deleted, builds break) and deviates from the project's established supply-chain pattern where all other dependencies point to organizational repos.

⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.

Suggested change
GIT_REPOSITORY https://github.com/MatthewBonanni/flash-attention.git
GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Copy link
Copy Markdown
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@MatthewBonanni MatthewBonanni enabled auto-merge (squash) May 31, 2026 04:13
@lucianommartins
Copy link
Copy Markdown
Contributor

👀

@vllm-bot vllm-bot merged commit ea0d045 into vllm-project:main Jun 2, 2026
165 of 178 checks passed
@MatthewBonanni MatthewBonanni deleted the sync_fa_2 branch June 2, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants