[Bugfix] Fall back to buffered I/O if O_DIRECT fails in secondary tier fs#44016
Closed
micah-wil wants to merge 2 commits into
Closed
[Bugfix] Fall back to buffered I/O if O_DIRECT fails in secondary tier fs#44016micah-wil wants to merge 2 commits into
micah-wil wants to merge 2 commits into
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Member
orozery
requested changes
May 30, 2026
Collaborator
orozery
left a comment
There was a problem hiding this comment.
@AndreasKaratzas I think this is a dup of #43689.
Can you verify it solves the issue on the AMD CI?
See the discussion there: I don't want to use a fallback, but instead make sure the buffers are aligned.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue exposed in the
V1 Core + KV + Metricstest group in AMD CI:(e.g. build 8978)
The
test_fs_tier.pytest was added recently in #41735, which implements file system secondary tier for multi-tier offload. The implementation relies onO_DIRECTin the store and load methods, but doesn't allow for any sort of fallback if it fails. This PR implements a fallback becauseO_DIRECTaccess fails in AMD CI. Theos.openandos.writecalls returnEINVALwithO_DIRECTenabled. This isn't inherently a ROCm specific issue, but it is sensitive to things like linux kernel version https://stackoverflow.com/questions/41257656/what-does-o-direct-really-mean.With the fallback in place, I am seeing the following when running the test: