Repository navigation
Conversation
bf4335f to
d0c8367
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: xunzhuo <xunzhuo@vllm-semantic-router.ai>
d0c8367 to
86bfbae
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
BugenZhao
left a comment
There was a problem hiding this comment.
Thanks for the work. The overall implementation LGTM
|
|
||
| #[try_stream] | ||
| async fn chat_completion_parallel_chunk_stream( | ||
| stream: impl Stream<Item = Result<ChatCompletionStreamEvent, ApiError>>, |
There was a problem hiding this comment.
What about explicitly specify SelectAll<ChatCompletionEventStream> here so the semantics are more clear?
| /// Whether the caller asked for the final streamed usage chunk. | ||
| pub include_usage: bool, | ||
| /// Number of chat completion choices requested by the caller. | ||
| pub n: u32, |
There was a problem hiding this comment.
Maybe renaming variable will make the variable's purpose clearer?
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it. Thank you! |
This adds Rust frontend parity for OpenAI
n > 1on/v1/completionsand/v1/chat/completions.This PR was prepared with AI assistance.
Highlights:
Only n=1 is supportedcompatibility rejection.nchoices into child frontend requests, using child request IDs only whenn > 1so existingn=1request-id behavior is preserved.[DONE]sentinel.Test Plan
n > 1validation and route behavior for chat/completions, both streaming and non-streaming.vllm-servertest suite.Test Result
cargo fmtgit diff --checkcargo test -p vllm-server(178 passed, 0 failed)cargo test -p vllm-server non_stream_chat_completions_fans_out_choice_request_ids_and_seedscargo test -p vllm-server non_stream_completions_fans_out_choice_request_ids_and_seedscargo test -p vllm-server non_stream_chat_completions_support_n_greater_than_onecargo test -p vllm-server stream_chat_completions_support_n_greater_than_onecargo test -p vllm-server non_stream_completions_support_n_greater_than_onecargo test -p vllm-server stream_completions_support_n_greater_than_oneNot run:
cargo nextestbecausecargo-nextestis not installed in this environment.Essential Elements of an Effective PR Description Checklist