[ROCm][Critical] Fix the GDN import bug#43486
Merged
Merged
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Member
Author
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import path for GatedDeltaNetAttention to its new location in vllm.model_executor.layers.mamba.gdn.base within the ROCm Aiter fusion pass and the fusion test suite. It also adds a type ignore annotation to handle type-checking issues during layer discovery. I have no feedback to provide as the existing review comments were purely explanatory and did not identify any issues.
4 tasks
DarkLight1337
approved these changes
May 23, 2026
ZJY0516
approved these changes
May 23, 2026
lrioxh
pushed a commit
to lrioxh/vllm-dev
that referenced
this pull request
May 24, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 26, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Liuweixiong0118
pushed a commit
to Liuweixiong0118/vllm
that referenced
this pull request
Jun 1, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> Signed-off-by: Liuweixiong0118 <lwx34158427@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#41126 changes the import of gdn thus causing import error. However this import error is critical as it will cause the server to crashed when we use
VLLM_ROCM_USE_AITER=1Test Plan
fix unit test
pytest -svvvv tests/compile/passes/test_fusion.py::test_aiter_fusion_rmsnorm_gated_quantEvaluate that the following command works and model generate correct end to end accuracy
Test Result
pytest -svvvv tests/compile/passes/test_fusion.py::test_aiter_fusion_rmsnorm_gated_quantQwen/Qwen3-Next-80B-A3B-Instruct-FP8Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.