Skip to content

[ROCm][DSv4][Perf] Optimized HIP kernel for sparse mla #43306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heachary wants to merge 16 commits into from
Closed

[ROCm][DSv4][Perf] Optimized HIP kernel for sparse mla #43306

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
37734f4
replacing sparse mla triton kernel with an optimized HIP version
heachary May 21, 2026
2419a51
add gfx950 gate
heachary May 21, 2026
0a5f08a
shifted HIP source to csrc
heachary May 25, 2026
6c91f49
added unit test for sparse mla
heachary May 25, 2026
2afbaba
remove _path function
heachary May 25, 2026
941e6b4
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
heachary May 27, 2026
8863212
move sparse mla hip kernel compilation to cmake
heachary May 28, 2026
e706489
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
heachary Jun 1, 2026
6ca69d6
parameterise the sparse mla hip unit test for dsv4 params
heachary Jun 5, 2026
3aa14d2
remove sparse mla extension
heachary Jun 5, 2026
c6d6ace
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
heachary Jun 5, 2026
a65900f
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
tjtanaa Jun 6, 2026
efc8b3a
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
tjtanaa Jun 6, 2026
74334ce
remove sparse mla extension
heachary Jun 8, 2026
35733af
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
mergify[bot] Jun 9, 2026
23f0b03
Merge branch 'main' into heachary/dsrv4/sparse_mla_PR
tjtanaa Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,6 +1316,32 @@ if(VLLM_GPU_LANG STREQUAL "HIP")
USE_SABI 3
WITH_SOABI)

#
# _rocm_sparse_mla_C extension (gfx950 only)
#
list(FIND VLLM_GPU_ARCHES "gfx950" _gfx950_idx)
if(NOT _gfx950_idx EQUAL -1)
set(VLLM_ROCM_SPARSE_MLA_SRC
"csrc/rocm/sparse_mla_decode.cu")

set(VLLM_ROCM_SPARSE_MLA_FLAGS ${VLLM_GPU_FLAGS}
"-Wno-c++11-narrowing")

define_extension_target(
_rocm_sparse_mla_C

@tjtanaa tjtanaa Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should compile it into _rocm_C as well. Your code will need to be guarded by GPU ARCH macros.

@heachary heachary Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i removed the extension and added the source into _rocm_C (for gfx950 only)

DESTINATION vllm
LANGUAGE ${VLLM_GPU_LANG}
SOURCES ${VLLM_ROCM_SPARSE_MLA_SRC}
COMPILE_FLAGS ${VLLM_ROCM_SPARSE_MLA_FLAGS}
ARCHITECTURES "gfx950"
USE_SABI 3
WITH_SOABI)

message(STATUS "Building ROCm sparse MLA decode kernel for gfx950.")
else()
message(STATUS "Not building ROCm sparse MLA decode kernel (gfx950 not in target architectures).")
endif()

if(VLLM_ROCM_HAS_GFX1100)
target_compile_definitions(_rocm_C PRIVATE VLLM_ROCM_GFX1100)
endif()
Expand Down
Loading
Loading