Revert "[Bugfix] mamba: run single-token extends as decodes (#42430)"#43176
Open
khluu wants to merge 1 commit into
Open
Revert "[Bugfix] mamba: run single-token extends as decodes (#42430)"#43176khluu wants to merge 1 commit into
khluu wants to merge 1 commit into
Conversation
…ject#42430)" This reverts commit 47829b1.
khluu
requested review from
ApostaC,
LucasWilkinson,
MatthewBonanni and
orozery
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the logic that automatically converted single-token Mamba prefills with prior state into decodes within the _compute_common_metadata method. Consequently, the MockMambaBuilder utility and several associated unit tests that relied on this behavior have been deleted or refactored to use a local _ConcreteMambaBuilder for testing persistent buffer allocations. I have no feedback to provide as there were no review comments.
Contributor
|
I also have a proposal to fix the CI failure without reverting at #43186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Bugfix] mamba: run single-token extends as decodes (#42430)) to investigate test regressions.Test plan