Revert "[Bugfix] mamba: run single-token extends as decodes" (#42430)#43034
Draft
vllm-agent wants to merge 1 commit into
Draft
Revert "[Bugfix] mamba: run single-token extends as decodes" (#42430)#43034vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
…ject#42430)" This reverts commit 47829b1.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the logic in the Mamba attention backend that automatically converts single-token prefills with prior state into decodes. Along with this change, the PR removes associated tests and refactors the test suite by deleting the shared MockMambaBuilder utility in favor of a local concrete implementation within the test files. I have no feedback to provide as there were no review comments to assess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #42430
This reverts commit 47829b1 (PR #42430).
Reason: CI nightly build #66759 detected 1 new failure linked to this PR:
test_accuracyfails withAssertionError: Expected: 0.8 | Measured: 0.7498104624715694— accuracy regressed from 0.80 to 0.75 for granite-4.0-h-tiny hybrid SSM model with HMA enabled.Original PR: #42430
Auto-generated by CI failure analyzer.