Skip to content

[Bugfix] Fix MultiConnector state corruption in P/D disaggregated con… #42841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NUABO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix] Fix MultiConnector state corruption in P/D disaggregated con… #42841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion vllm/distributed/kv_transfer/kv_connector/v1/multi_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,13 +381,23 @@ def update_state_after_alloc(
):
chosen_connector = self._requests_to_connector.get(request.request_id, -1)
empty_blocks = blocks.new_empty()
# When a specific connector was chosen to load KV for this request,
# mask out kv_transfer_params for the others so they don't
# incorrectly start async transfers for a request they do not own.
# When no connector was chosen (e.g. producer side or no remote
# match), leave params intact so producer logic and full-prefix-hit
# handling still run.
masked_request = request
if chosen_connector >= 0:
masked_request = copy.copy(request)
masked_request.kv_transfer_params = None
for i, c in enumerate(self._connectors):
if i == chosen_connector:
# Forward call to the chosen connector (if any).
c.update_state_after_alloc(request, blocks, num_external_tokens)
else:
# Call with empty blocks for other connectors.
c.update_state_after_alloc(request, empty_blocks, 0)
c.update_state_after_alloc(masked_request, empty_blocks, 0)

def on_new_request(self, request: "Request") -> None:
for c in self._connectors:
Expand Down
Loading