[Models][Qwen3VL] Fix MM encoder cuda graph input capture#42639
Closed
lgeiger wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Lukas Geiger <lukas.geiger94@gmail.com>
eee7c70 to
289cedf
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the prepare_encoder_cudagraph_capture_inputs method in vllm/model_executor/models/qwen3_vl.py to use ceiling division when calculating per_mm_item_output, ensuring the captured capacity is never smaller than the token_budget. I have no feedback to provide as there were no review comments to evaluate.
Contributor
|
This bug was fixed in #38040. |
Isotr0py
approved these changes
May 14, 2026
Member
|
Duplicate of #38040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Using a MM encoder CUDA graph currently fails with for Qwen3VL with:
Qwen2VL and Qwen2.5VL already use ceil to ensure that the capture capacity is never smaller than the token budget:
vllm/vllm/model_executor/models/qwen2_vl.py
Lines 1586 to 1587 in 6548560
vllm/vllm/model_executor/models/qwen2_5_vl.py
Lines 1727 to 1731 in 6548560
This PR is a followup on #35963 and applies the same fix to Qwen3VL. /cc @Isotr0py @b-mu
Test Plan
Test Result
Server starts up properly