Skip to content

fix: propagate revision/code_revision pins to all artifact boundaries - #42616

Merged
vllm-bot merged 4 commits into
vllm-project:mainfrom
jperezdealgaba:fix/propagate-revision-pins
May 15, 2026
Merged

vllm-bot merged 4 commits into
vllm-project:mainfrom
jperezdealgaba:fix/propagate-revision-pins

Conversation

@jperezdealgaba

Copy link
Copy Markdown
Contributor

Summary

When an operator supplies --revision or --code-revision, vLLM did not consistently forward these pins to all artifact load paths. This patch closes six pin-decay gaps so that every code, config, processor, and weight artifact loaded for a model resolves under the operator's configured revision.

Fixes

  • registry.py: forward code_revision to try_get_class_from_dynamic_module
  • gguf_loader.py: pass revision to hf_hub_download for repo/file.gguf
  • roberta.py: use model_config.revision for BGE-M3 secondary weights
  • kimi_k25.py: pass revision to cached_get_image_processor
  • kimi_audio.py: pass revision to WhisperConfig.from_pretrained and secondary whisper-large-v3 weight source

Test plan

  • Updated test_gguf_download.py to verify revision and cache_dir are passed through in _prepare_weights
  • Remaining fixes are pass-through parameter additions; covered by existing integration tests when --revision is supplied

Signed-off-by: jperezde jperezde@redhat.com

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the new-model Requests to new models label May 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several model loaders and configurations to consistently use the revision and code_revision attributes from the model configuration. Specifically, it modifies the GGUF loader, Kimi Audio, Kimi K25, and RoBERTa models, as well as the model registry, to ensure that specific model versions are correctly identified during download and initialization. I have no feedback to provide.

@mergify

mergify Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Hi @jperezdealgaba, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

When an operator supplies --revision or --code-revision, vLLM did not
consistently forward these pins to all artifact load paths. This patch
closes six pin-decay gaps so that every code, config, processor, and
weight artifact loaded for a model resolves under the operator's
configured revision.
Fixes:
- registry.py: forward code_revision to try_get_class_from_dynamic_module
- gguf_loader.py: pass revision to hf_hub_download for repo/file.gguf
- roberta.py: use model_config.revision for BGE-M3 secondary weights
- kimi_k25.py: pass revision to cached_get_image_processor
- kimi_audio.py: pass revision to WhisperConfig.from_pretrained and
  secondary whisper-large-v3 weight source

Signed-off-by: jperezde <jperezde@redhat.com>
@jperezdealgaba
jperezdealgaba force-pushed the fix/propagate-revision-pins branch from 37d5df0 to 54d1835 Compare May 14, 2026 08:23

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337
DarkLight1337 enabled auto-merge (squash) May 14, 2026 09:26
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 14, 2026
@jperezdealgaba

Copy link
Copy Markdown
Contributor Author

@DarkLight1337 Do you mind checking this? I think the errors are not caused by my changes

@DarkLight1337

Copy link
Copy Markdown
Member

That failure should be fixed on main already, let's rebase and see if the tests pass now

@vllm-bot
vllm-bot merged commit d26a28a into vllm-project:main May 15, 2026
59 of 61 checks passed
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
…vllm-project#42616)

Signed-off-by: jperezde <jperezde@redhat.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
h1t35h pushed a commit to h1t35h/vllm that referenced this pull request May 21, 2026
…vllm-project#42616)

Signed-off-by: jperezde <jperezde@redhat.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Liuweixiong0118 pushed a commit to Liuweixiong0118/vllm that referenced this pull request Jun 1, 2026
…vllm-project#42616)

Signed-off-by: jperezde <jperezde@redhat.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: Liuweixiong0118 <lwx34158427@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants