[CI] Fix test_async_scheduling.py flakiness#42455
Merged
Merged
Conversation
Signed-off-by: Nick Hill <nickhill123@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the rank comparison in the asynchronous scheduling end-to-end tests by introducing a relative tolerance using pytest.approx. The review feedback points out that a relative tolerance is too restrictive for small integer ranks and fails to account for cases where the rank might be None, which would lead to a TypeError. A suggestion was provided to use an absolute tolerance and maintain safe handling for None values.
khluu
approved these changes
May 12, 2026
yewentao256
approved these changes
May 12, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
4 tasks
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
May 19, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 21, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has become super flakey recently, e.g. https://buildkite.com/vllm/ci/builds/65896/canvas?sid=019e1d8a-5417-4923-8772-6383caefd793&tab=output
I think this started after #41411.
It looks like because we are now comparing prompt logprobs, ranks can be much larger and the difference between their logprob values much smaller, in some cases meaning the order changes and so the ranks can be off by one or two.
Adding tolerance to the rank comparison will hopefully resolve this.