[CI] De-flake Language Models Test (Extended Generation) test_models(False-False-5-32-bigcode/starcoder2-3b)#42392
Merged
DarkLight1337 merged 1 commit intoMay 12, 2026
Conversation
bigcode/starcoder2-3b fails models/language/generation/test_common.py on L4 (SM 8.9). The failure is on Test1, an open-ended NL prompt fed to a code-completion model. After 8 matched tokens the model wanders into a Jupyter notebook markdown id and lands in a near-uniform digit-token logit region; HF and vLLM disagree on which digit lands in top-5 by ~1 logprob bit, so `output_id_0 in logprobs_elem_1` fails. Replace Test1 only for bigcode/starcoder2-3b with a code prompt that keeps the model on its training distribution and produces sharp top-1 logits at every position. Other models are unchanged. Verified locally on GB10: both parametrizations PASS in ~95s each. Signed-off-by: haosdent <haosdent@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the common generation tests in tests/models/language/generation/test_common.py to specifically handle the bigcode/starcoder2-3b model. It replaces a natural language prompt with a code-based prompt to mitigate test instability caused by logit drift between Hugging Face and vLLM implementations. I have no feedback to provide as there were no review comments.
Contributor
Author
DarkLight1337
approved these changes
May 12, 2026
Contributor
|
Thank you! |
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…False-False-5-32-bigcode/starcoder2-3b) (vllm-project#42392) Signed-off-by: haosdent <haosdent@gmail.com>
1 task
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…False-False-5-32-bigcode/starcoder2-3b) (vllm-project#42392) Signed-off-by: haosdent <haosdent@gmail.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…False-False-5-32-bigcode/starcoder2-3b) (vllm-project#42392) Signed-off-by: haosdent <haosdent@gmail.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 21, 2026
…False-False-5-32-bigcode/starcoder2-3b) (vllm-project#42392) Signed-off-by: haosdent <haosdent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the long-standing CI failure for
bigcode/starcoder2-3bintests/models/language/generation/test_common.pyon L4 (SM 8.9). Tracked in #37304 and #42336; #42336 narrows the regression window to08bfedc15..2488d1dcwhich contains #34644 (PyTorch 2.10 → 2.11)Test1 is an open-ended NL prompt fed to a code-completion model. After ~8 matched tokens starcoder2-3b wanders into a Jupyter-style markdown id and lands in a near-uniform digit-token logit region; HF↔vLLM bf16 drift over 30 layers reorders top-K by one logprob bit, so
output_id_0 in logprobs_elem_1fails. Replace Test1 only for this model with a code prompt that keeps it on its training distribution; other models are unchanged.Recent failing daily/nightly runs (all on L4): #65678, #65498, #65468, #65423, #65378, #65324, #65246, #65099, #65033, #64859, #64792.
Test Plan
Test Result