[Frontend] Consolidate Speech to Text entrypoints.#42370
Conversation
b0c942a to
2760b16
Compare
There was a problem hiding this comment.
Code Review
This pull request reorganizes the speech-to-text and realtime entrypoints into a dedicated vllm/entrypoints/speech_to_text package, moving them out of the OpenAI-specific directory. It introduces a factories.py module to consolidate API router registration and state initialization. The reviewer suggests using relative imports for consistency within the new package and recommends explicitly initializing state attributes to None in the factory function to prevent potential AttributeError when certain tasks are not supported.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Purpose
Following #41907 #42274
Consolidate Speech to Text entrypoints.
Test Plan
pytest -v -s entrypoints/speech_to_text
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.