[CI] Move DockerHub and PyPI publish steps to end of release pipeline#42355
Conversation
Move the "Publish release images to DockerHub" and "Publish wheels to PyPI" steps to the very end of the pipeline so all build steps (including ROCm) complete before the final publish actions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Code Review
This pull request moves the DockerHub and PyPI publishing steps to the end of the Buildkite release pipeline to ensure all builds are finished before publishing. A review comment suggests adding a condition to the Publish wheels group to prevent manual confirmation blocks from appearing during nightly builds.
| DOCKER_BUILDKIT: "1" | ||
| DOCKERHUB_USERNAME: "vllmbot" | ||
|
|
||
| - group: "Publish wheels" |
There was a problem hiding this comment.
The Publish wheels group is missing the if: build.env("NIGHTLY") != "1" condition. While this inconsistency existed in the original position, moving these steps to the end of the pipeline is a good opportunity to ensure that release-specific manual blocks do not appear during automated nightly builds. Adding this condition will prevent the PyPI confirmation block from showing up in nightly pipelines.
- group: "Publish wheels"
if: build.env("NIGHTLY") != "1"
key: "publish-wheels"|
@khluu maybe you want to trigger a dryrun and see if it works? |
|
I created a job here and the 2 jobs got moved to the end of the pipeline https://buildkite.com/vllm/release-v2/builds/1517 |
…vllm-project#42355) Signed-off-by: khluu <khluu000@gmail.com>
…vllm-project#42355) Signed-off-by: khluu <khluu000@gmail.com>
…vllm-project#42355) Signed-off-by: khluu <khluu000@gmail.com>
…vllm-project#42355) Signed-off-by: khluu <khluu000@gmail.com>
Summary
Test plan
depends_onreferences still resolve to the correct step IDs🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com