Skip to content

[CI] Move DockerHub and PyPI publish steps to end of release pipeline#42355

Merged
khluu merged 1 commit into
mainfrom
ci/move-publish-steps-to-end
May 12, 2026
Merged

[CI] Move DockerHub and PyPI publish steps to end of release pipeline#42355
khluu merged 1 commit into
mainfrom
ci/move-publish-steps-to-end

Conversation

@khluu
Copy link
Copy Markdown
Member

@khluu khluu commented May 12, 2026

Summary

  • Moved the "Publish release images to DockerHub" block + step and the "Publish wheels to PyPI" group to the very end of the release pipeline
  • All build steps (including ROCm) now complete before the final publish actions
  • No changes to dependencies or step logic — only positional reordering

Test plan

  • Verify the Buildkite pipeline YAML parses correctly
  • Confirm depends_on references still resolve to the correct step IDs
  • Trigger a dry-run release build to validate step ordering

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Move the "Publish release images to DockerHub" and "Publish wheels to
PyPI" steps to the very end of the pipeline so all build steps (including
ROCm) complete before the final publish actions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: khluu <khluu000@gmail.com>
@khluu khluu requested a review from Harry-Chen as a code owner May 12, 2026 00:50
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@mergify mergify Bot added the ci/build label May 12, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the DockerHub and PyPI publishing steps to the end of the Buildkite release pipeline to ensure all builds are finished before publishing. A review comment suggests adding a condition to the Publish wheels group to prevent manual confirmation blocks from appearing during nightly builds.

DOCKER_BUILDKIT: "1"
DOCKERHUB_USERNAME: "vllmbot"

- group: "Publish wheels"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Publish wheels group is missing the if: build.env("NIGHTLY") != "1" condition. While this inconsistency existed in the original position, moving these steps to the end of the pipeline is a good opportunity to ensure that release-specific manual blocks do not appear during automated nightly builds. Adding this condition will prevent the PyPI confirmation block from showing up in nightly pipelines.

  - group: "Publish wheels"
    if: build.env("NIGHTLY") != "1"
    key: "publish-wheels"

@Harry-Chen
Copy link
Copy Markdown
Member

@khluu maybe you want to trigger a dryrun and see if it works?

@khluu khluu added this to the v0.21.0 cherry picks milestone May 12, 2026
@khluu
Copy link
Copy Markdown
Member Author

khluu commented May 12, 2026

I created a job here and the 2 jobs got moved to the end of the pipeline https://buildkite.com/vllm/release-v2/builds/1517

@khluu khluu enabled auto-merge (squash) May 12, 2026 08:46
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 12, 2026
@khluu khluu merged commit e1c8776 into main May 12, 2026
22 checks passed
@khluu khluu deleted the ci/move-publish-steps-to-end branch May 12, 2026 09:17
khluu added a commit that referenced this pull request May 12, 2026
…#42355)

Signed-off-by: khluu <khluu000@gmail.com>
(cherry picked from commit e1c8776)
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
h1t35h pushed a commit to h1t35h/vllm that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants