[MoE Refactor] Move remaining experts classes to experts directory#42334
Merged
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
bnellnm
requested review from
WoosukKwon,
jeejeelee,
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the MoE (Mixture of Experts) module by moving several expert-related files into a dedicated experts subdirectory. Import statements across various files, including tests, LoRA layers, and quantization configurations, have been updated to reflect this new directory structure. Additionally, a type hint was added to the packed_modules_mapping attribute in HummingConfig. I have no feedback to provide.
mergify
Bot
added
performance
yewentao256
approved these changes
May 11, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
github-project-automation
Bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
Signed-off-by: Bill Nell <bnell@redhat.com>
Contributor
|
Documentation preview: https://vllm--42334.org.readthedocs.build/en/42334/ |
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
yewentao256
approved these changes
May 12, 2026
github-project-automation
Bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…llm-project#42334) Signed-off-by: Bill Nell <bnell@redhat.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…llm-project#42334) Signed-off-by: Bill Nell <bnell@redhat.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…llm-project#42334) Signed-off-by: Bill Nell <bnell@redhat.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 21, 2026
…llm-project#42334) Signed-off-by: Bill Nell <bnell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move the remaining experts subclasses to the
expertsdirectory.cc @yzong-rh
Test Plan
Lint + CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.