Skip to content

[Metrics] Scope unregister_vllm_metrics() to PrometheusStatLogger-owned metrics #42331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vraiti wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

[Metrics] Scope unregister_vllm_metrics() to PrometheusStatLogger-owned metrics #42331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8116ba
Scope unregister_vllm_metrics to strictly "vllm:"
vraiti May 13, 2026
2f74bab
Merge branch 'main' into feat/precise-unregister
vraiti May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/v1/metrics/prometheus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def unregister_vllm_metrics():
registry = REGISTRY
# Unregister any existing vLLM collectors
for collector in list(registry._collector_to_names):
if hasattr(collector, "_name") and "vllm" in collector._name:
if hasattr(collector, "_name") and collector._name.startswith("vllm:"):
registry.unregister(collector)


Expand Down
Loading