[Bugfix] Fix DeepSeek V4 MTP HC state handling - #42320
Merged
WoosukKwon merged 2 commits intoMay 13, 2026
Merged
Conversation
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com> (cherry picked from commit 245c137)
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DeepSeek-V4 model implementation by modifying the forward method in deepseek_v4.py to return a tuple of four tensors instead of a single tensor. In deepseek_v4_mtp.py, the mtp_block call is updated to unpack these four values, which are then passed to a new hc_post call. I have no feedback to provide as there were no review comments.
gnovack
reviewed
May 11, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
|
LGTM Accuracy is aligned |
gnovack
approved these changes
May 12, 2026
1 task
khluu
pushed a commit
that referenced
this pull request
May 15, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com> (cherry picked from commit f1cc7aa)
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
May 19, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 21, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Mohammad Miadh Angkad <176301910+mmangkad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the DeepSeek V4 MTP path after #41536 changed
DeepseekV4DecoderLayer.forwardto takepost_mix,res_mix, andresidual. The main model path was updated, but the MTP draft layer still used the old call and failed at startup/profile run. Key error lines:This updates the MTP call site and fixes the
DeepseekV4DecoderLayer.forwardreturn annotation.Before this fix, DeepSeek V4 with MTP failed to start. After this fix, it starts successfully.
cc @WoosukKwon