Skip to content

[Frontend]Responses API supports chat_template_kwargs#42272

Merged
DarkLight1337 merged 3 commits into
vllm-project:mainfrom
chaunceyjiang:responseapi_chat_template_kwargs
May 11, 2026
Merged

[Frontend]Responses API supports chat_template_kwargs#42272
DarkLight1337 merged 3 commits into
vllm-project:mainfrom
chaunceyjiang:responseapi_chat_template_kwargs

Conversation

@chaunceyjiang

@chaunceyjiang chaunceyjiang commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Responses API supports chat_template_kwargs

Test Plan

see e2e

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the frontend label May 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for chat_template_kwargs in the OpenAI Responses API, enabling the passing of keyword arguments to the chat template renderer through both request parameters and server-level defaults. Feedback indicates that the default_chat_template_kwargs are not being propagated to the preprocess_chat method in the rendering logic, which causes server-level defaults to be ignored.

Comment thread vllm/entrypoints/openai/responses/serving.py Outdated
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 11, 2026 06:26
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2026
@DarkLight1337 DarkLight1337 merged commit 617239b into vllm-project:main May 11, 2026
42 checks passed
@chaunceyjiang chaunceyjiang deleted the responseapi_chat_template_kwargs branch May 12, 2026 07:11
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
h1t35h pushed a commit to h1t35h/vllm that referenced this pull request May 21, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528 pushed a commit to knight0528/vllm that referenced this pull request Jun 8, 2026
…2272)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants