[CI][BugFix] Fix failure CI "amd-v1-sample-plus-logits-mi300-1"#42106
[CI][BugFix] Fix failure CI "amd-v1-sample-plus-logits-mi300-1"#42106SoluMilken wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the mocking of custom logits processor entry points in tests by replacing in-memory patching of importlib.metadata with a more robust mechanism that creates temporary .dist-info files and updates the PYTHONPATH. This ensures that mocked entry points are correctly discovered by spawned worker processes. Feedback was provided regarding the construction of the PYTHONPATH environment variable, as the current implementation could result in a trailing separator that inadvertently adds the current working directory to the search path, potentially leading to non-hermetic tests.
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
b8f6833 to
287b48e
Compare
|
Hi @afeldman-nm @dzhengAP could you please take a look? This fixes the ROCm logits processor entrypoint test failures by replacing the in-process Thanks. |
|
@SoluMilken thanks!there is an earlier PR discussed to fix this fork issue. Are they similar? #42040 |
|
Hi dzhengAP, they are almost the same. Let me close this PR. |
Purpose
Fix failure CI:
amd-v1-sample-plus-logits-mi300-1https://buildkite.com/vllm/ci/builds/65147/canvas?jid=019e06e7-5882-42b3-8c44-6723201294ea&tab=output
https://buildkite.com/vllm/ci/builds/65109/canvas?jid=019e0656-76cd-445e-8324-cfe4b042f924&tab=output
https://buildkite.com/vllm/ci/builds/65102/canvas?jid=019e0637-d718-43e0-b285-eaab513fd44e&tab=output
Root Cause
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)