[MoE Refactor] Move capture state out of FusedMoE/MoERunner#41997
Closed
bnellnm wants to merge 11 commits into
Closed
[MoE Refactor] Move capture state out of FusedMoE/MoERunner#41997bnellnm wants to merge 11 commits into
bnellnm wants to merge 11 commits into
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the routing capture mechanism for MoE layers by centralizing the logic for writing to the routing replay buffer within the FusedMoERouter and introducing a layer ID mapping system in RoutedExpertsCapturer. The manual buffer writing previously handled in MoeRunner has been removed. A critical issue was identified in fused_moe_router.py where the select_experts method remains decorated with @AbstractMethod despite now having a concrete implementation, which would prevent the instantiation of its subclasses.
bnellnm
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
yzong-rh
reviewed
May 10, 2026
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Contributor
|
Documentation preview: https://vllm--41997.org.readthedocs.build/en/41997/ |
yzong-rh
approved these changes
May 11, 2026
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
4 tasks
Collaborator
Author
|
The original PR that required this change got reverted, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move capture related state out of
FusedMoEsince it is going away andMoERunneris being refactored.Related to: #39917
cc @yzong-rh , @TomerBN-Nvidia
Test Plan
Ran
tests/model_executor/test_routed_experts_capture.pyTest Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)