[Compressed Tensors] Allow configs with non-explicit ignores#41965
Merged
vllm-bot merged 3 commits intovllm-project:mainfrom May 7, 2026
Merged
[Compressed Tensors] Allow configs with non-explicit ignores#41965vllm-bot merged 3 commits intovllm-project:mainfrom
vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors find_matched_target to return None instead of raising a ValueError when a target is not found, updating the calling logic in compressed_tensors.py to handle these cases explicitly. Feedback was provided regarding a potential AttributeError in get_scheme_dict if the retrieved scheme dictionary is None, along with a suggestion to avoid in-place modifications of the configuration dictionary.
mgoin
approved these changes
May 7, 2026
Member
mgoin
left a comment
There was a problem hiding this comment.
LGTM Kyle, thanks for cleaning up the ValueError. Can you add a unit test to solidify this expected behavior?
dsikka
approved these changes
May 7, 2026
Contributor
dsikka
left a comment
There was a problem hiding this comment.
LGTM but we should probably add a basic smoke test for this.
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
libinta
pushed a commit
to libinta/vllm
that referenced
this pull request
May 8, 2026
…oject#41965) Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously:
Now:
Changes
find_matched_targetto returnNone, and treat a non-match against schemes as an ignored layerTesting
test_find_matched_target_returns_none_on_no_matchtest_get_scheme_dict_returns_none_on_no_match