[Bugfix] DeepSeekV32/v4: respect string='true|false' attribute andunwrap arguments/input wrapper#41801
Merged
sfeng33 merged 2 commits intovllm-project:mainfrom May 6, 2026
Merged
Conversation
…ute andunwrap arguments/input wrapper Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…ute andunwrap arguments/input wrapper Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the DeepSeek tool parsers (V3.2 and V4) by implementing support for the string="true" attribute in tool call parameters, which ensures values are preserved as strings regardless of the schema. It also introduces a _repair_param_dict method to automatically unwrap tool arguments that models occasionally nest within arguments or input keys. Corresponding unit tests have been added for both streaming and non-streaming scenarios to verify these improvements. I have no feedback to provide as no review comments were submitted.
This was referenced May 6, 2026
sfeng33
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: QwertyJack
Purpose
respect string='true|false' attribute andunwrap arguments/input wrapper
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.