Skip to content

[Bugfix] DeepSeekV32/v4: respect string='true|false' attribute andunwrap arguments/input wrapper#41801

Merged
sfeng33 merged 2 commits intovllm-project:mainfrom
chaunceyjiang:dsv32_string
May 6, 2026
Merged

[Bugfix] DeepSeekV32/v4: respect string='true|false' attribute andunwrap arguments/input wrapper#41801
sfeng33 merged 2 commits intovllm-project:mainfrom
chaunceyjiang:dsv32_string

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented May 6, 2026

Co-Authored-By: QwertyJack

Purpose

respect string='true|false' attribute andunwrap arguments/input wrapper

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

…ute andunwrap arguments/input wrapper

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…ute andunwrap arguments/input wrapper

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mergify mergify Bot added deepseek Related to DeepSeek models tool-calling bug Something isn't working labels May 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the DeepSeek tool parsers (V3.2 and V4) by implementing support for the string="true" attribute in tool call parameters, which ensures values are preserved as strings regardless of the schema. It also introduces a _repair_param_dict method to automatically unwrap tool arguments that models occasionally nest within arguments or input keys. Corresponding unit tests have been added for both streaming and non-streaming scenarios to verify these improvements. I have no feedback to provide as no review comments were submitted.

@chaunceyjiang chaunceyjiang marked this pull request as ready for review May 6, 2026 10:44
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@sfeng33 sfeng33 added the ready ONLY add when PR is ready to merge/full CI is needed label May 6, 2026
@sfeng33 sfeng33 enabled auto-merge (squash) May 6, 2026 20:10
@sfeng33 sfeng33 merged commit 9558286 into vllm-project:main May 6, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants