-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
[Perf] Use numpy zero-copy path for embedding float response serialization #41681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vllm-bot
merged 8 commits into
vllm-project:main
from
lokashrinav:perf/embedding-response-numpy-fast-path
May 8, 2026
+105
−0
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b4882af
[Perf] Use numpy zero-copy path for embedding float response serializ…
lokashrinav a647038
Use Pydantic models for response structure in fast path
lokashrinav 4764a4f
Fix test to not require orjson at import time
lokashrinav 70cda15
Merge branch 'main' into perf/embedding-response-numpy-fast-path
noooop 0a8e492
Fix ruff formatting in serving.py
lokashrinav 94a5053
Fix mypy type errors in embedding serving and tests
lokashrinav 58777ac
Merge branch 'main' into perf/embedding-response-numpy-fast-path
mergify[bot] b74c85d
Merge branch 'main' into perf/embedding-response-numpy-fast-path
lokashrinav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
|
|
||
| import importlib | ||
| import importlib.util | ||
| import json | ||
| import warnings | ||
| from types import SimpleNamespace | ||
|
|
||
| import numpy as np | ||
| import pytest | ||
| import torch | ||
|
|
||
| from vllm.entrypoints.pooling.utils import encode_pooling_output_float_or_ndarray | ||
|
|
||
|
|
||
| def _pooling_output(data): | ||
| return SimpleNamespace(outputs=SimpleNamespace(data=data)) | ||
|
|
||
|
|
||
| def test_encode_pooling_output_float_or_ndarray_returns_numpy_array(): | ||
| output = _pooling_output(torch.tensor([1.0, 2.0, 3.0], dtype=torch.float32)) | ||
|
|
||
| encoded = encode_pooling_output_float_or_ndarray(output) | ||
|
|
||
| assert isinstance(encoded, np.ndarray) | ||
| np.testing.assert_allclose(encoded, [1.0, 2.0, 3.0]) | ||
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| importlib.util.find_spec("orjson") is None, | ||
| reason="orjson is not installed", | ||
| ) | ||
| def test_orjson_serializes_numpy_array(): | ||
| from fastapi.responses import ORJSONResponse | ||
|
|
||
| output = _pooling_output(torch.tensor([1.0, 2.0, 3.0], dtype=torch.float32)) | ||
| encoded = encode_pooling_output_float_or_ndarray(output) | ||
|
|
||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", DeprecationWarning) | ||
| response = ORJSONResponse(content={"embedding": encoded}) | ||
| assert json.loads(response.body)["embedding"] == pytest.approx([1.0, 2.0, 3.0]) | ||
|
|
||
|
|
||
| def test_encode_pooling_output_float_or_ndarray_falls_back_to_list(): | ||
| class DataWithUnsupportedNumpy: | ||
| def is_contiguous(self): | ||
| return True | ||
|
|
||
| def numpy(self): | ||
| raise TypeError("unsupported dtype") | ||
|
|
||
| def tolist(self): | ||
| return [1.0, 2.0, 3.0] | ||
|
|
||
| output = _pooling_output(DataWithUnsupportedNumpy()) | ||
|
|
||
| assert encode_pooling_output_float_or_ndarray(output) == [1.0, 2.0, 3.0] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.