[Build] Switch CUDA 12.9 wheel builds to PyTorch manylinux_2_28 base#41668
Open
[Build] Switch CUDA 12.9 wheel builds to PyTorch manylinux_2_28 base#41668
Conversation
Mirror the cu130 wheel build switch from #41416 onto cu129 so the published cu129 wheels also get a glibc 2.28 floor (matching PyTorch's own published wheels). cu129 release Docker image builds and the runtime container are unchanged. Signed-off-by: mgoin <mgoin64@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .buildkite/release-pipeline.yaml file to include BUILD_OS and BUILD_BASE_IMAGE as build arguments in the Docker build commands for both ARM64 and x86 architectures. These changes specify the use of manylinux and corresponding PyTorch builder images for the release process. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #41416. Mirror the cu130 wheel build switch onto cu129 so the published cu129 wheels also get a glibc 2.28 floor (via
pytorch/manylinux2_28-builder:cuda12.9/pytorch/manylinuxaarch64-builder:cuda12.9), matching PyTorch's own published wheels.Scope is intentionally minimal — only the two cu129 wheel-build steps in
.buildkite/release-pipeline.yaml. cu129 release Docker image builds,FINAL_BASE_IMAGE, and the runtime container are unchanged (same trade-off as #41416).Test Plan
auditwheel showreportsmanylinux_2_28on the produced cu129 wheelsTest Result
Pending validation in release pipeline.
AI assistance (Claude) was used to draft this change.