[Docs] Add non-causal support to attention backend docs - #41643
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Documentation preview: https://vllm--41643.org.readthedocs.build/en/41643/ |
MatthewBonanni
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a "Non-Causal" (bidirectional) attention support column to the attention backend documentation and updates the generation script to populate this field. Review feedback suggests clarifying the definition of non-causal attention for decoder models and improving code formatting consistency in the script.
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
noooop
approved these changes
May 4, 2026
noooop
enabled auto-merge (squash)
May 4, 2026 18:27
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
May 7, 2026
…#41643) Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…#41643) Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…#41643) Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Given the popularity of DFlash, we should report non-causal support in the attention backend documentation. This PR adds this column.
Test Plan
Docs build should succeed (docs-only PR)
Test Result
TBD
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.