Skip to content

Revert "[Doc] Fix RTD build: pytorch.org/docs/stable/objects.inv returns 404" - #41618

Merged
hmellor merged 2 commits into
vllm-project:mainfrom
stecasta:revert-41353-stecasta/fix-rtd-pytorch-inventory
May 4, 2026
Merged

hmellor merged 2 commits into
vllm-project:mainfrom
stecasta:revert-41353-stecasta/fix-rtd-pytorch-inventory

Conversation

@stecasta

@stecasta stecasta commented May 4, 2026

Copy link
Copy Markdown
Contributor

Fixed upstream by pytorch/docs#85. pytorch.org/docs/stable/objects.inv is back, byte-identical to the /docs/2.11/ pin.

Reverts #41353

@stecasta
stecasta requested a review from hmellor as a code owner May 4, 2026 10:00

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mkdocs.yaml configuration to point the PyTorch documentation link back to the stable version and removes the associated TODO comment. I have no feedback to provide.

@mergify

mergify Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Hi @stecasta, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

…rns 404 …"

This reverts commit 3527229.

Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
@stecasta
stecasta force-pushed the revert-41353-stecasta/fix-rtd-pytorch-inventory branch from fc275b6 to e2b4ccb Compare May 4, 2026 10:10
@mergify

mergify Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Hi @stecasta, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@stecasta

stecasta commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Pre-commit failure here is unrelated to this revert. Fix up at #41620.

@hmellor

hmellor commented May 4, 2026

Copy link
Copy Markdown
Member

Thanks, please update the branch and we can use auto merge

@stecasta

stecasta commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi @hmellor, it should be good now.

@hmellor
hmellor enabled auto-merge (squash) May 4, 2026 10:45
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 4, 2026
@hmellor
hmellor merged commit 62ba751 into vllm-project:main May 4, 2026
9 checks passed
Copilot AI pushed a commit to hongbolv/vllm that referenced this pull request May 7, 2026
…rns 404" (vllm-project#41618)

Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
…rns 404" (vllm-project#41618)

Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
…rns 404" (vllm-project#41618)

Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
hustcui pushed a commit to hustcui/vllm-hust that referenced this pull request Jul 10, 2026
…rns 404" (vllm-project#41618)

Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants