Skip to content

[Build] Fix CPU extension build on macOS ARM64 #41538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guru-meesho wants to merge 1 commit into from
+9 −2
Closed

[Build] Fix CPU extension build on macOS ARM64 #41538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ cmake_minimum_required(VERSION 3.26)
# cmake --install . --component _C
project(vllm_extensions LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)


Expand Down
2 changes: 1 addition & 1 deletion cmake/cpu_extension.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include(FetchContent)

set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_EXTENSIONS ON)
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

Expand Down
7 changes: 7 additions & 0 deletions csrc/cpu/cpu_types_arm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,13 @@ struct FP32Vec16 : public VectorizedRegWrapper<FP32Vec16, 4, float> {
std::tie(reg.val[2], reg.val[3]) = convert_bfloat16_float(v.reg.val[1]);
};

explicit FP32Vec16(const BF16Vec32& v, int upper) {
int base = upper ? 2 : 0;
std::tie(reg.val[0], reg.val[1]) = convert_bfloat16_float(v.reg.val[base]);
std::tie(reg.val[2], reg.val[3]) =
convert_bfloat16_float(v.reg.val[base + 1]);
};

explicit FP32Vec16(const BF16Vec8& v) : FP32Vec16(FP32Vec8(v)) {};

explicit FP32Vec16(const FP16Vec16& v) {
Expand Down
Loading