Revert "[Build] Make bundled DeepGEMM wheel portable across Python versions"#41512
Merged
Revert "[Build] Make bundled DeepGEMM wheel portable across Python versions"#41512
Conversation
…rsions (…" This reverts commit 0c99629.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the CMake configuration for the deepgemm external project by removing the logic for free-threaded Python checks and Stable ABI (SABI) support. It also removes the explicit library output directory for the _deep_gemm_C target and associated compile options that were used to manage Py_LIMITED_API. I have no feedback to provide.
7 tasks
joa-stdn
pushed a commit
to joa-stdn/vllm
that referenced
this pull request
May 4, 2026
…rsions" (vllm-project#41512) Signed-off-by: Joachim Studnia <joachim@mistral.ai>
chaojun-zhang
pushed a commit
to chaojun-zhang/vllm
that referenced
this pull request
May 6, 2026
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
May 7, 2026
…rsions" (vllm-project#41512) Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #41476 as the approach is not actually viable for pybind11-based bindings