[Refactor] Remove dead code in tests and parallel_state#41471
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
requested review from
ApostaC,
NickLucche,
orozery and
xuechendi
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the codebase by removing unused testing utilities and deprecated distributed parallel state functions. Key changes include the removal of the set_cycles_before_xfer_done method and its references in unit tests, the deletion of the remote_tokens metric from KV connector stats, and the simplification of the update_finished_set logic. Additionally, several legacy functions and a context manager were removed from vllm/distributed/parallel_state.py. I have no feedback to provide.
NickLucche
left a comment
NickLucche
left a comment
There was a problem hiding this comment.
looks ok but re: test I would be more interested in finding out if set_cycles_before_xfer_done had an implementation
| ) | ||
| aggregated_kv_connector_stats = aggregated_kv_connector_stats.aggregate( | ||
| kv_connector_stats | ||
| ) |
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
CC @NickLucche if we could land this PR
| return get_tp_group().rank_in_group | ||
|
|
||
|
|
||
| def get_decode_context_model_parallel_world_size() -> int: |
There was a problem hiding this comment.
@DarkLight1337 seems that @youkaichao is quite busy recently, check again this is not used at all, could we land this PR in this case?
…#41471) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…#41471) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: JisoLya <523420504@qq.com>
…#41471) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…#41471) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
…#41471) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
5 participants
Purpose
Remove dead code