Skip to content

[Bugfix] Fix spawn_new_process_for_each_test silently swallowing test failures#41423

Merged
ProExpertProg merged 11 commits into
vllm-project:mainfrom
dzhengAP:bugfix/fix-spawn-decorator-exitcode
May 6, 2026
Merged

[Bugfix] Fix spawn_new_process_for_each_test silently swallowing test failures#41423
ProExpertProg merged 11 commits into
vllm-project:mainfrom
dzhengAP:bugfix/fix-spawn-decorator-exitcode

Remove dangling old spawn function body

e80a2a1
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 1, 2026 in 6m 26s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/utils.py:22 Unused import multiprocessing

Annotations

Check warning on line 22 in tests/utils.py

See this annotation in the file changed.

@claude claude / Claude Code Review

Unused import multiprocessing

The diff adds `import multiprocessing` at tests/utils.py:22, but the bare `multiprocessing` module name is never referenced in the file (the existing `from multiprocessing import Process` on line 23 already covers what's used). Ruff's F401 will flag this as an unused import — the PR's pre-commit job has already failed once, so this is likely contributing. Removing the line fixes it.